linux-kernel - Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on Intel NUC boxes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Aug 2020 10:13:36 +0200
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     吳昊澄 Ricky <ricky_wu@...ltek.com>
Cc:     Chris Clayton <chris2553@...glemail.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "philquadra@...il.com" <philquadra@...il.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader
 on Intel NUC boxes

On Tue, Aug 04, 2020 at 08:08:10AM +0000, 吳昊澄 Ricky wrote:
> > -----Original Message-----
> > From: gregkh@...uxfoundation.org [mailto:gregkh@...uxfoundation.org]
> > Sent: Tuesday, August 04, 2020 3:49 PM
> > To: 吳昊澄 Ricky
> > Cc: Chris Clayton; LKML; rdunlap@...radead.org; philquadra@...il.com; Arnd
> > Bergmann
> > Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on
> > Intel NUC boxes
> > 
> > On Tue, Aug 04, 2020 at 02:44:41AM +0000, 吳昊澄 Ricky wrote:
> > > Hi Chris,
> > >
> > > rtsx_pci_write_register(pcr, FPDTL, OC_POWER_DOWN, OC_POWER_DOWN);
> > > This register operation saved power under 1mA, so if do not care the 1mA
> > power we can have a patch to remove it, make compatible with NUC6
> > > We tested others our card reader that remove it, we did not see any side effect
> > >
> > > Hi Greg k-h,
> > >
> > > Do you have any comments?
> > 
> > comments on what?  I don't know what you are responding to here, sorry.
> > 
> Can we have a patch to kernel for NUC6? It may cause more power(1mA)
> but it will have more compatibility

I do not understand at all, sorry.

greg k-h