lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Aug 2020 08:24:03 +0000 From: Wei Yongjun <weiyongjun1@...wei.com> To: Paul Cercueil <paul@...pouillou.net>, Krzysztof Kozlowski <krzk@...nel.org> CC: Wei Yongjun <weiyongjun1@...wei.com>, <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>, Hulk Robot <hulkci@...wei.com> Subject: [PATCH] memory: jz4780-nemc: Fix return value check in jz4780_nemc_probe() In case of error, the function devm_ioremap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: f046e4a3f0b9 ("memory: jz4780_nemc: Only request IO memory the driver will use") Reported-by: Hulk Robot <hulkci@...wei.com> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com> --- drivers/memory/jz4780-nemc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/memory/jz4780-nemc.c b/drivers/memory/jz4780-nemc.c index 3ec5cb0fce1e..608ae925e641 100644 --- a/drivers/memory/jz4780-nemc.c +++ b/drivers/memory/jz4780-nemc.c @@ -304,9 +304,9 @@ static int jz4780_nemc_probe(struct platform_device *pdev) } nemc->base = devm_ioremap(dev, res->start, NEMC_REG_LEN); - if (IS_ERR(nemc->base)) { + if (!nemc->base) { dev_err(dev, "failed to get I/O memory\n"); - return PTR_ERR(nemc->base); + return -ENOMEM; } writel(0, nemc->base + NEMC_NFCSR);
Powered by blists - more mailing lists