linux-kernel - Re: [PATCH] mac80211: use eth_zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <0def73ad11944166a0a01391627cc02d@huawei.com>
Date:   Tue, 4 Aug 2020 11:43:24 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     "johannes@...solutions.net" <johannes@...solutions.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mac80211: use eth_zero_addr() to clear mac address

> David Miller wrote:
>>From: linmiaohe <linmiaohe@...wei.com>
>>Date: Sat, 1 Aug 2020 17:12:38 +0800
>>
>> From: Miaohe Lin <linmiaohe@...wei.com>
>> 
>> Use eth_zero_addr() to clear mac address instead of memset().
>> 
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>
>If you're going to make this change, you should probably convert this macro to use eth_addr_copy() at the same time.

Many thanks for your reply. I think we should not convert this macro to use ether_addr_copy (). Because ether_addr_copy() required
@dst and @src must both be aligned to u16 and we may not always meet this condition.

Thanks again.