linux-kernel - Re: [PATCH v1 3/3] kernel/configs: don't include PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f80cfa932a650d8f7e8fc02a1656b4c2@kernel.org>
Date:   Tue, 04 Aug 2020 14:46:26 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Alex Bennée <alex.bennee@...aro.org>
Cc:     kvm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, kvmarm@...ts.cs.columbia.edu,
        christoffer.dall@....com
Subject: Re: [PATCH  v1 3/3] kernel/configs: don't include PCI_QUIRKS in KVM
 guest configs

On 2020-08-04 13:44, Alex Bennée wrote:
> The VIRTIO_PCI support is an idealised PCI bus, we don't need a bunch
> of bloat for real world hardware for a VirtIO guest.

Who says this guest will only have virtio devices?

Or even, virtio devices without bugs? Given that said device can
come from any VMM, I'm not sure this is the right thing to do.

Thanks,

         M.

> 
> Signed-off-by: Alex Bennée <alex.bennee@...aro.org>
> ---
>  kernel/configs/kvm_guest.config | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/configs/kvm_guest.config 
> b/kernel/configs/kvm_guest.config
> index 208481d91090..672863a2fdf1 100644
> --- a/kernel/configs/kvm_guest.config
> +++ b/kernel/configs/kvm_guest.config
> @@ -13,6 +13,7 @@ CONFIG_IP_PNP_DHCP=y
>  CONFIG_BINFMT_ELF=y
>  CONFIG_PCI=y
>  CONFIG_PCI_MSI=y
> +CONFIG_PCI_QUIRKS=n
>  CONFIG_DEBUG_KERNEL=y
>  CONFIG_VIRTUALIZATION=y
>  CONFIG_HYPERVISOR_GUEST=y

-- 
Jazz is not dead. It just smells funny...