linux-kernel - Re: [PATCH] scsi: lpfc: Add the missed misc_deregister() for lpfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ace2c669-5fc6-e6c5-9d39-382ba02b1adf@broadcom.com>
Date:   Tue, 4 Aug 2020 09:21:23 -0700
From:   James Smart <james.smart@...adcom.com>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>,
        dick.kennedy@...adcom.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: lpfc: Add the missed misc_deregister() for
 lpfc_init()



On 7/30/2020 11:56 PM, Jing Xiangfeng wrote:
> lpfc_init() misses to call misc_deregister() in an error path. Add a
> label 'unregister' to fix it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>
> ---
>   drivers/scsi/lpfc/lpfc_init.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
>
Looks fine.

Reviewed-by: James Smart <james.smart@...adcom.com>


Thanks

-- james