linux-kernel - Re: False positive in checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 04 Aug 2020 10:54:00 -0700
From:   Joe Perches <joe@...ches.com>
To:     "Kumar K, Anil" <anil.kumar.k@...el.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: False positive in checkpatch.pl

On Tue, 2020-08-04 at 17:44 +0000, Kumar K, Anil wrote:
> Hi Joe,

Hello.

Please always cc linux-kernel@...r.kernel.org

> I noticed a false positive while executing checkpatch.pl. Checkpatch
> identifies the * as multiplication I guess. I saw there was some
> discussion about this before. Was there a workaround/fix for this ?
> Can u please share if so. Thanks for your time
> 
> ERROR: need consistent spacing around '*' (ctx:WxV)
> #8195: FILE: src/soc/intel/abc/include/soc/romstage.h:21:
> +void mainboard_memory_init_params(FSPM_UPD *mupd);

Basically, avoid typedefs.

Either have the typedef available for checkpatch in the same
file or don't use typedefs at all.

If your project has multiple typedefs and these messages
annoy you, you could add --typedefsfile=<filepath> to the
checkpatch command line where <filepath> contains a
one entry per line list of the typedefs used.