linux-kernel - Re: [PATCH] net: dev: Add API to check net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200804192435.GG1919070@lunn.ch>
Date:   Tue, 4 Aug 2020 21:24:35 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ilia Lin <ilia.lin@...il.com>
Cc:     David Miller <davem@...emloft.net>, ilial@...eaurora.org,
        kuba@...nel.org, jiri@...lanox.com, edumazet@...gle.com,
        ap420073@...il.com, xiyou.wangcong@...il.com, maximmi@...lanox.com,
        Ilia Lin <ilia.lin@...nel.org>, netdev@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: dev: Add API to check net_dev readiness

On Tue, Aug 04, 2020 at 08:47:18PM +0300, Ilia Lin wrote:
> Hi Andrew and David,

Hi Ilia

Please don't top post.

> 
> Thank you for your comments!
> 
> The client driver is still work in progress, but it can be seen here:
> https://source.codeaurora.org/quic/la/kernel/msm-4.19/tree/drivers/platform/msm/ipa/ipa_api.c#n3842
> 
> For HW performance reasons, it has to be in subsys_initcall.

Well, until the user of this new API is ready, we will not accept the
patch.

You also need to explain "For HW performance reasons". Why is this
driver special that it can do things which no over driver does?

And you should really be working on net-next, not this dead kernel
version, if you want to get merged into mainline.

Network drivers do not belong is drivers/platform. There is also ready
a drivers/net/ipa, so i assume you will move there.

  Andrew