linux-kernel - Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring pair request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200805113237.GX12965@vkoul-mobl>
Date:   Wed, 5 Aug 2020 17:02:37 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Peter Ujfalusi <peter.ujfalusi@...com>
Cc:     ssantosh@...nel.org, santosh.shilimkar@...cle.com,
        linux-arm-kernel@...ts.infradead.org, grygorii.strashko@...com,
        linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org
Subject: Re: [PATCH] dmaengine: ti: k3-udma-glue: Fix parameters for rx ring
 pair request

On 05-08-20, 14:27, Peter Ujfalusi wrote:
> The original commit mixed up the forward and completion ring IDs for the
> rx flow configuration.

Acked-By: Vinod Koul <vkoul@...nel.org>

> 
> Fixes: 4927b1ab2047 ("dmaengine: ti: k3-udma: Switch to k3_ringacc_request_rings_pair")
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---
> Hi Santosh, Vinod,
> 
> the offending patch was queued via ti SoC tree.
> Santosh, can you pick up this fix also?
> 
> Regards,
> Peter
> 
>  drivers/dma/ti/k3-udma-glue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c
> index 3a5d33ea5ebe..12da38a92218 100644
> --- a/drivers/dma/ti/k3-udma-glue.c
> +++ b/drivers/dma/ti/k3-udma-glue.c
> @@ -579,8 +579,8 @@ static int k3_udma_glue_cfg_rx_flow(struct k3_udma_glue_rx_channel *rx_chn,
>  
>  	/* request and cfg rings */
>  	ret =  k3_ringacc_request_rings_pair(rx_chn->common.ringacc,
> -					     flow_cfg->ring_rxq_id,
>  					     flow_cfg->ring_rxfdq0_id,
> +					     flow_cfg->ring_rxq_id,
>  					     &flow->ringrxfdq,
>  					     &flow->ringrx);
>  	if (ret) {
> -- 
> Peter
> 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

-- 
~Vinod