linux-kernel - Re: [PATCH v19 08/15] mm/damon: Add a tracepoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 Aug 2020 08:23:05 +0200
From:   SeongJae Park <sjpark@...zon.com>
To:     Steven Rostedt <rostedt@...dmis.org>
CC:     SeongJae Park <sjpark@...zon.com>,
        SeongJae Park <sjpark@...zon.de>,
        <Jonathan.Cameron@...wei.com>, <aarcange@...hat.com>,
        <acme@...nel.org>, <alexander.shishkin@...ux.intel.com>,
        <amit@...nel.org>, <benh@...nel.crashing.org>,
        <brendan.d.gregg@...il.com>, <brendanhiggins@...gle.com>,
        <cai@....pw>, <colin.king@...onical.com>, <corbet@....net>,
        <david@...hat.com>, <dwmw@...zon.com>, <fan.du@...el.com>,
        <foersleo@...zon.de>, <gthelen@...gle.com>, <irogers@...gle.com>,
        <jolsa@...hat.com>, <kirill@...temov.name>, <mark.rutland@....com>,
        <mgorman@...e.de>, <minchan@...nel.org>, <mingo@...hat.com>,
        <namhyung@...nel.org>, <peterz@...radead.org>,
        <rdunlap@...radead.org>, <riel@...riel.com>, <rientjes@...gle.com>,
        <rppt@...nel.org>, <sblbir@...zon.com>, <shakeelb@...gle.com>,
        <shuah@...nel.org>, <sj38.park@...il.com>, <snu@...zon.de>,
        <vbabka@...e.cz>, <vdavydov.dev@...il.com>,
        <yang.shi@...ux.alibaba.com>, <ying.huang@...el.com>,
        <linux-damon@...zon.com>, <linux-mm@...ck.org>,
        <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v19 08/15] mm/damon: Add a tracepoint

On Tue, 4 Aug 2020 18:01:47 -0400 Steven Rostedt <rostedt@...dmis.org> wrote:

> On Tue, 4 Aug 2020 11:14:09 +0200
> SeongJae Park <sjpark@...zon.com> wrote:
> 
> > From: SeongJae Park <sjpark@...zon.de>
> > 
> > This commit adds a tracepoint for DAMON.  It traces the monitoring
> > results of each region for each aggregation interval.  Using this, DAMON
> > can easily integrated with tracepoints supporting tools such as perf.
> > 
> > Signed-off-by: SeongJae Park <sjpark@...zon.de>
> > Reviewed-by: Leonard Foerster <foersleo@...zon.de>
> > ---
> >  include/trace/events/damon.h | 43 ++++++++++++++++++++++++++++++++++++
> >  mm/damon.c                   |  4 ++++
> >  2 files changed, 47 insertions(+)
> >  create mode 100644 include/trace/events/damon.h
> > 
[...]
> > --- a/mm/damon.c
> > +++ b/mm/damon.c
> > @@ -20,6 +20,8 @@
> >  
> >  #define pr_fmt(fmt) "damon: " fmt
> >  
> > +#define CREATE_TRACE_POINTS
> > +
> >  #include <linux/damon.h>
> >  #include <linux/delay.h>
> >  #include <linux/kthread.h>
> > @@ -31,6 +33,7 @@
> >  #include <linux/sched/mm.h>
> >  #include <linux/sched/task.h>
> >  #include <linux/slab.h>
> 
> It's best to place the #define CREATE_TRACE_POINTS here, so that it
> doesn't cause any side effects when including the other headers.

Agreed, I will do so in the next spin!

> 
> Other than that:
> 
> Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> 
> -- Steve


Thanks,
SeongJae Park