linux-kernel - Re: [PATCH v11 00/28] Add support for mt2701 JPEG ENC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc3d16ad-fd05-5bab-8a16-dc5ba0ef671c@xs4all.nl>
Date:   Wed, 5 Aug 2020 10:45:49 +0200
From:   Hans Verkuil <hverkuil-cisco@...all.nl>
To:     Xia Jiang <xia.jiang@...iatek.com>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Rick Chang <rick.chang@...iatek.com>
Cc:     linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Tomasz Figa <tfiga@...omium.org>, srv_heupstream@...iatek.com,
        senozhatsky@...omium.org, mojahsu@...omium.org,
        drinkcat@...omium.org, maoguang.meng@...iatek.com
Subject: Re: [PATCH v11 00/28] Add support for mt2701 JPEG ENC support

On 04/08/2020 05:40, Xia Jiang wrote:
> This patchset add support for mt2701 JPEG ENC support.      

I'm getting these compile warnings/errors:

drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ‘mtk_jpeg_enc_device_run’:
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:917:27: warning: variable ‘jpeg_src_buf’ set but not used [-Wunused-but-set-variable]

  917 |  struct mtk_jpeg_src_buf *jpeg_src_buf;
      |                           ^~~~~~~~~~~~

It's indeed not used.

drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ‘mtk_jpeg_suspend’:
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1482:2: error: implicit declaration of function ‘v4l2_m2m_suspend’; did you mean ‘v4l2_m2m_mmap’? [-Werror=implicit-function-declaration]

 1482 |  v4l2_m2m_suspend(jpeg->m2m_dev);
      |  ^~~~~~~~~~~~~~~~
      |  v4l2_m2m_mmap
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ‘mtk_jpeg_resume’:
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1495:2: error: implicit declaration of function ‘v4l2_m2m_resume’; did you mean ‘v4l2_m2m_release’? [-Werror=implicit-function-declaration]

 1495 |  v4l2_m2m_resume(jpeg->m2m_dev);
      |  ^~~~~~~~~~~~~~~
      |  v4l2_m2m_release

This apparently relies on https://lore.kernel.org/linux-arm-kernel/20191204124732.10932-2-Jerry-Ch.chen@mediatek.com/

Please add this patch to this series. Don't forget to add Tomasz' 'Reviewed-by' line.

drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ‘mtk_jpeg_enc_g_selection’:
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:525:8: warning: this statement may fall through [-Wimplicit-fallthrough=]

  525 |   s->r = ctx->out_q.enc_crop_rect;
      |   ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:526:2: note: here
  526 |  case V4L2_SEL_TGT_CROP_BOUNDS:
      |  ^~~~

This is definitely wrong. A break is missing here.

Regards,

	Hans