linux-kernel - Re: [PATCH] ARM: at91: pm: remove unnecessary at91sam9x60

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1af8bb51-85e1-d58e-cc5c-4c4e379f83c4@microchip.com>
Date:   Wed, 5 Aug 2020 08:52:06 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <alexandre.belloni@...tlin.com>, <Nicolas.Ferre@...rochip.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: at91: pm: remove unnecessary at91sam9x60_idle



On 04.08.2020 14:56, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> cpu_do_idle() is already the default action for arm_pm_idle, there is no
> need to open code it.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>

> ---
>  arch/arm/mach-at91/pm.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index 074bde64064e..19cc0d5b149b 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -557,11 +557,6 @@ static void at91rm9200_idle(void)
>         writel(AT91_PMC_PCK, soc_pm.data.pmc + AT91_PMC_SCDR);
>  }
> 
> -static void at91sam9x60_idle(void)
> -{
> -       cpu_do_idle();
> -}
> -
>  static void at91sam9_idle(void)
>  {
>         writel(AT91_PMC_PCK, soc_pm.data.pmc + AT91_PMC_SCDR);
> @@ -842,7 +837,7 @@ void __init sam9x60_pm_init(void)
> 
>         at91_pm_modes_init();
>         at91_dt_ramc();
> -       at91_pm_init(at91sam9x60_idle);
> +       at91_pm_init(NULL);
> 
>         soc_pm.ws_ids = sam9x60_ws_ids;
>         soc_pm.config_pmc_ws = at91_sam9x60_config_pmc_ws;
> --
> 2.26.2
>