linux-kernel - Re: [External] linux-next: build warning after merge of the ftrace tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200806020445.649ddaa8b8ec1b91e23508e4@kernel.org>
Date:   Thu, 6 Aug 2020 02:04:45 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Muchun Song <songmuchun@...edance.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Chengming Zhou <zhouchengming@...edance.com>,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [External] linux-next: build warning after merge of the ftrace
 tree

On Wed, 5 Aug 2020 11:11:05 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Wed, 5 Aug 2020 12:53:39 +0800
> Muchun Song <songmuchun@...edance.com> wrote:
> 
> > On Wed, Aug 5, 2020 at 12:21 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> > >
> > > Hi all,
> > >
> > > After merging the ftrace tree, today's linux-next build (powerpc
> > > ppc64_defconfig) produced this warning:
> > >
> > > kernel/kprobes.c: In function 'kill_kprobe':
> > > kernel/kprobes.c:1116:33: warning: statement with no effect [-Wunused-value]
> > >  1116 | #define disarm_kprobe_ftrace(p) (-ENODEV)
> > >       |                                 ^
> > > kernel/kprobes.c:2154:3: note: in expansion of macro 'disarm_kprobe_ftrace'
> > >  2154 |   disarm_kprobe_ftrace(p);
> > >       |   ^~~~~~~~~~~~~~~~~~~~
> > >  
> > 
> > Sorry, maybe we should rework the macro of disarm_kprobe_ftrace to an
> > inline function like below.
> > 
> > -#define disarm_kprobe_ftrace(p)        (-ENODEV)
> > +static inline int disarm_kprobe_ftrace(struct kprobe *p)
> > +{
> > +       return -ENODEV
> > +}
> >  #endif
> 
> Looks like that would work. Care to send a formal patch. Could you also
> change arm_kprobe_ftrace() as well?

Looks good to me too as far as updating it to static inline function.

Thank you,

-- 
Masami Hiramatsu <mhiramat@...nel.org>