linux-kernel - Re: [PATCH] net: openvswitch: silence suspicious RCU usage warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <323728A6-9ED5-4588-92D5-3F6799357D0A@redhat.com>
Date:   Wed, 05 Aug 2020 21:21:13 +0200
From:   "Eelco Chaudron" <echaudro@...hat.com>
To:     xiangxia.m.yue@...il.com
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        pshelar@....org, syzkaller-bugs@...glegroups.com,
        dev@...nvswitch.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: openvswitch: silence suspicious RCU usage warning



On 5 Aug 2020, at 9:19, xiangxia.m.yue@...il.com wrote:

> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
>
> ovs_flow_tbl_destroy always is called from RCU callback
> or error path. It is no need to check if rcu_read_lock
> or lockdep_ovsl_is_held was held.
>
> ovs_dp_cmd_fill_info always is called with ovs_mutex,
> So use the rcu_dereference_ovsl instead of rcu_dereference
> in ovs_flow_tbl_masks_cache_size.
>
> Fixes: 9bf24f594c6a ("net: openvswitch: make masks cache size 
> configurable")
> Cc: Eelco Chaudron <echaudro@...hat.com>
> Reported-by: syzbot+c0eb9e7cdde04e4eb4be@...kaller.appspotmail.com
> Reported-by: syzbot+f612c02823acb02ff9bc@...kaller.appspotmail.com
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>

Thanks for fixing this, I was (am) on PTO so did not notice it earlier!

Cheers,

Eelco