linux-kernel - Re: [PATCH 5.7 0/6] 5.7.14-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEUSe78hB1-FtRVagj_pVFAbrAgXdzHas5ub7Rf-Qf8O+_0NWA@mail.gmail.com>
Date:   Wed, 5 Aug 2020 14:26:17 -0500
From:   Daniel Díaz <daniel.diaz@...aro.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Ben Hutchings <ben.hutchings@...ethink.co.uk>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        patches@...nelci.org, lkft-triage@...ts.linaro.org,
        open list <linux-kernel@...r.kernel.org>,
        linux- stable <stable@...r.kernel.org>,
        Marc Zyngier <maz@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Shuah Khan <shuah@...nel.org>, Willy Tarreau <w@....eu>
Subject: Re: [PATCH 5.7 0/6] 5.7.14-rc1 review

Hello!

On Wed, 5 Aug 2020 at 13:37, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
> On Wed, Aug 5, 2020 at 11:24 AM Guenter Roeck <linux@...ck-us.net> wrote:
> >
> > Same with older versions of gcc. I don't see the problem with the
> > mainline kernel.
>
>   https://www.youtube.com/watch?v=-b5aW08ivHU
>
> > I think this is caused by more recursive includes.
> > arch/arm64/include/asm/archrandom.h includes include/linux/random.h
> > which includes arch/arm64/include/asm/archrandom.h to get the definition
> > of arch_get_random_seed_long_early (which it won't get because of
> > the recursion).
> >
> > What I don't really understand is how this works with new versions
> > of gcc.
>
> Is that the only place it triggers?

Yes

> Because the trivial fix would be something like the appended, which is
> the right thing to do anyway.
>
>               Linus
>
> diff --git a/arch/arm64/kernel/kaslr.c b/arch/arm64/kernel/kaslr.c
> index 07c4c8cc4a67..9ded4237e1c1 100644
> --- a/arch/arm64/kernel/kaslr.c
> +++ b/arch/arm64/kernel/kaslr.c
> @@ -11,8 +11,8 @@
>  #include <linux/sched.h>
>  #include <linux/types.h>
>  #include <linux/pgtable.h>
> +#include <linux/random.h>
>
> -#include <asm/archrandom.h>
>  #include <asm/cacheflush.h>
>  #include <asm/fixmap.h>
>  #include <asm/kernel-pgtable.h>

Tested-by: Daniel Díaz <daniel.diaz@...aro.org>

This patch works fine. Built with gcc 7.3.0 and glibc 2.27.

Greetings!

Daniel Díaz
daniel.diaz@...aro.org