linux-kernel - Re: drivers/input/touchscreen/elants_i2c.c:859:45: warning: Clarify calculation precedence for '&' and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Aug 2020 15:31:05 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     kernel test robot <lkp@...el.com>
Cc:     Johnny Chuang <johnny.chuang@....com.tw>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Peter Hutterer <peter.hutterer@...-t.net>
Subject: Re: drivers/input/touchscreen/elants_i2c.c:859:45: warning: Clarify
 calculation precedence for '&' and

On Sun, Aug 02, 2020 at 06:18:19AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   d52daa8620c65960e1ef882adc1f92061326bd7a
> commit: f27ad8932725f8dd0cd1a46763de4a40377b1ae6 Input: elants_i2c - support palm detection
> date:   4 months ago
> compiler: xtensa-linux-gcc (GCC) 9.3.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> 
> cppcheck warnings: (new ones prefixed by >>)
> 
> >> drivers/input/touchscreen/elants_i2c.c:859:45: warning: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
>     tool_type = buf[FW_POS_TOOL_TYPE] & BIT(0) ?
>                                                ^

No, there is no need to clarify precedence as it is already clear.

Thanks.

-- 
Dmitry