[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200806223453.GK1665100@dtor-ws>
Date: Thu, 6 Aug 2020 15:34:53 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Colin King <colin.king@...onical.com>
Cc: linux-input@...r.kernel.org, kernel-janitors@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] input: ims-pcu: return error code rather than -ENOMEM
On Wed, Jun 03, 2020 at 04:21:51PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Currently the assignment of -ENOMEM to error is redudant because error
> is not being read and -ENOMEM is being hard coded as an error return.
> Fix this by returning the error code in variable 'error'; this also
> allows the error code from a failed call to input_register_device to
> be preserved and returned to the caller rather than just returning
> a possibly inappropriate -ENOMEM.
>
> Kudos to Dan Carpenter for the suggestion of an improved fix.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>
Applied, thank you.
--
Dmitry
Powered by blists - more mailing lists