linux-kernel - Re: [PATCH] mm/migrate: fix migrate_pgmap_owner w/o CONFIG_MMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Aug 2020 20:44:27 -0300
From:   Jason Gunthorpe <jgg@...lanox.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Ralph Campbell <rcampbell@...dia.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Jerome Glisse <jglisse@...hat.com>,
        John Hubbard <jhubbard@...dia.com>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] mm/migrate: fix migrate_pgmap_owner w/o
 CONFIG_MMU_NOTIFIER

On Thu, Aug 06, 2020 at 04:39:58PM -0700, Randy Dunlap wrote:
> On 8/6/20 12:33 PM, Ralph Campbell wrote:
> > On x86_64, when CONFIG_MMU_NOTIFIER is not set/enabled, there is a
> > compiler error:
> > 
> > ../mm/migrate.c: In function 'migrate_vma_collect':
> > ../mm/migrate.c:2481:7: error: 'struct mmu_notifier_range' has no member
> > named 'migrate_pgmap_owner'
> >   range.migrate_pgmap_owner = migrate->pgmap_owner;
> >        ^
> > 
> > Fixes: 998427b3ad2c ("mm/notifier: add migration invalidation type")
> > Signed-off-by: Ralph Campbell <rcampbell@...dia.com>
> > Reported-by: Randy Dunlap <rdunlap@...radead.org>
> 
> Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

I thought it spent enough time in linux-next and for 0-day to catch
things like this, but I guess I was wrong.

Linus has already merged the hmm pull request.

Andrew Morton: Can you pick this fix up to forward to Linus?

Thanks,
Jason