linux-kernel - Re: [PATCH] scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5F2BA901.3060206@huawei.com>
Date:   Thu, 6 Aug 2020 14:53:53 +0800
From:   Jing Xiangfeng <jingxiangfeng@...wei.com>
To:     <alim.akhtar@...sung.com>, <avri.altman@....com>,
        <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
        <vigneshr@...com>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: ufs: ti-j721e-ufs: Fix error return in
 ti_j721e_ufs_probe()

Please ignore this patch.
	Thanks

On 2020/8/6 14:44, Jing Xiangfeng wrote:
> Fix to return error code IS_ERR() from the error handling case instead
> of 0.
>
> Fixes: 22617e216331 ("scsi: ufs: ti-j721e-ufs: Fix unwinding of pm_runtime changes")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>
> ---
>   drivers/scsi/ufs/ti-j721e-ufs.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ufs/ti-j721e-ufs.c b/drivers/scsi/ufs/ti-j721e-ufs.c
> index 46bb905b4d6a..eafe7c08b0c8 100644
> --- a/drivers/scsi/ufs/ti-j721e-ufs.c
> +++ b/drivers/scsi/ufs/ti-j721e-ufs.c
> @@ -38,6 +38,7 @@ static int ti_j721e_ufs_probe(struct platform_device *pdev)
>   	/* Select MPHY refclk frequency */
>   	clk = devm_clk_get(dev, NULL);
>   	if (IS_ERR(clk)) {
> +		ret = IS_ERR(clk);
>   		dev_err(dev, "Cannot claim MPHY clock.\n");
>   		goto clk_err;
>   	}
>