[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20200805.174217.627457778756782771.davem@davemloft.net>
Date: Wed, 05 Aug 2020 17:42:17 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: min.li.xe@...esas.com
Cc: richardcochran@...il.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] ptp: ptp_idt82p33: update to support adjphase
From: <min.li.xe@...esas.com>
Date: Tue, 4 Aug 2020 15:12:14 -0400
> This update includes adjphase support, more debug logs, firmware name
> parameter, correct PTP_CLK_REQ_PEROUT support and use do_aux_work to
> do delay work.
Way too many changes in one patch, and some of them are not appropriate.
> +static char *firmware;
> +module_param(firmware, charp, 0);
We have various kernel interfaces for handling firmware loading and
names. Please use them instead of a custom module paramter. Module
paramters are significantly undesirable and addition of such will be
rejected by default.
Thank you.
Powered by blists - more mailing lists