| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20200806142906.GA796067@bogus>
Date: Thu, 6 Aug 2020 08:29:06 -0600
From: Rob Herring <robh@...nel.org>
To: Wesley Cheng <wcheng@...eaurora.org>
Cc: heikki.krogerus@...ux.intel.com, gregkh@...uxfoundation.org,
agross@...nel.org, bjorn.andersson@...aro.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
jackp@...eaurora.org, sboyd@...nel.org
Subject: Re: [PATCH v7 2/4] dt-bindings: usb: Add Qualcomm PMIC type C
controller dt-binding
On Mon, Aug 03, 2020 at 05:45:21PM -0700, Wesley Cheng wrote:
> Introduce the dt-binding for enabling USB type C orientation and role
> detection using the PM8150B. The driver will be responsible for receiving
> the interrupt at a state change on the CC lines, reading the
> orientation/role, and communicating this information to the remote
> clients, which can include a role switch node and a type C switch.
>
> Signed-off-by: Wesley Cheng <wcheng@...eaurora.org>
> ---
> .../bindings/usb/qcom,pmic-typec.yaml | 131 ++++++++++++++++++
> 1 file changed, 131 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> new file mode 100644
> index 000000000000..877e979f413f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> @@ -0,0 +1,131 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/usb/qcom,pmic-typec.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Qualcomm PMIC based USB type C Detection Driver
> +
> +maintainers:
> + - Wesley Cheng <wcheng@...eaurora.org>
> +
> +description: |
> + Qualcomm PMIC Type C Detect
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,pm8150b-usb-typec
> +
> + reg:
> + maxItems: 1
> + description: Type C base address
> +
> + interrupts:
> + maxItems: 1
> + description: CC change interrupt from PMIC
> +
> + connector:
> + description: Connector type for remote endpoints
> + type: object
> +
> + properties:
> + compatible:
> + $ref: /schemas/connector/usb-connector.yaml#/properties/compatible
usb-connector.yaml should be referenced from 'connector'.
> + enum:
> + - usb-c-connector
> +
> + power-role:
> + $ref: /schemas/connector/usb-connector.yaml#/properties/power-role
> + enum:
> + - dual
> + - source
> + - sink
Just 'power-role: true' is enough as this is the same set of possible
values.
> +
> + data-role:
> + $ref: /schemas/connector/usb-connector.yaml#/properties/data-role
> + enum:
> + - dual
> + - host
> + - device
Same here
> +
> + ports:
> + description: Remote endpoint connections
> + type: object
> + $ref: /schemas/connector/usb-connector.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + description: Remote endpoints for the High Speed path
> + type: object
> +
> + port@1:
> + description: Remote endpoints for the Super Speed path
> + type: object
> +
> + properties:
> + endpoint@0:
> + description: Connection to USB type C mux node
> + type: object
> +
> + properties:
> + remote-endpoint:
> + description: Node reference to the type C mux
You don't need to describe 'remote-endpoint'. You can assume that is
defined in a common graph schema (to be written).
> +
> + endpoint@1:
> + description: Connection to role switch node
> + type: object
> +
> + properties:
> + remote-endpoint:
> + description: Node reference to the role switch node
> +
> + required:
> + - compatible
> +
> +required:
> + - compatible
> + - interrupts
> + - connector
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + pm8150b {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pm8150b_typec: typec@...0 {
> + compatible = "qcom,pm8150b-usb-typec";
> + reg = <0x1500>;
> + interrupts = <0x2 0x15 0x5 IRQ_TYPE_EDGE_RISING>;
> +
> + connector {
> + compatible = "usb-c-connector";
> + power-role = "dual";
> + data-role = "dual";
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + };
> + port@1 {
> + reg = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + usb3_data_ss: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&qmp_ss_mux>;
> + };
> + usb3_role: endpoint@1 {
> + reg = <1>;
> + remote-endpoint = <&dwc3_drd_switch>;
> + };
> + };
> + };
> + };
> + };
> + };
> +...
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
Powered by blists - more mailing lists