linux-kernel - Re: [PATCH v4 2/6] dt-bindings: net: can: binding for CTU CAN FD open-source IP core.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200806144713.GA829771@bogus>
Date:   Thu, 6 Aug 2020 08:47:13 -0600
From:   Rob Herring <robh@...nel.org>
To:     Pavel Machek <pavel@....cz>, pisa@....felk.cvut.cz
Cc:     linux-can@...r.kernel.org, devicetree@...r.kernel.org,
        mkl@...gutronix.de, socketcan@...tkopp.net, wg@...ndegger.com,
        davem@...emloft.net, mark.rutland@....com, c.emde@...dl.org,
        armbru@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, martin.jerabek01@...il.com,
        ondrej.ille@...il.com, jnovak@....cvut.cz, jara.beran@...il.com,
        porazil@...ron.com
Subject: Re: [PATCH v4 2/6] dt-bindings: net: can: binding for CTU CAN FD
 open-source IP core.

On Tue, Aug 04, 2020 at 11:20:21AM +0200, Pavel Machek wrote:
> On Tue 2020-08-04 11:18:17, Pavel Machek wrote:
> > Hi!
> > 
> > > The commit text again to make checkpatch happy.
> > 
> > ?
> > 
> > 
> > > +    oneOf:
> > > +      - items:
> > > +          - const: ctu,ctucanfd
> > > +          - const: ctu,canfd-2
> > > +      - const: ctu,ctucanfd
> > 
> > For consistency, can we have ctu,canfd-1, ctu,canfd-2?
> 
> Make it ctu,ctucanfd-1, ctu,ctucanfd-2... to make it consistent with
> the file names.

If you are going to do version numbers, please define where they come 
from. Hopefully some tag of the h/w IP version...

Better yet, put version numbers in the h/w registers itself and you 
don't need different compatibles.

Rob