linux-kernel - drivers/net/ethernet/pensando/ionic/ionic_txrx.c:608:3: warning: Variable 'done' is modified but its new value is never used.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200806143735.GA9232@xsang-OptiPlex-9020>
Date:   Thu, 6 Aug 2020 22:37:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     Shannon Nelson <snelson@...sando.io>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: drivers/net/ethernet/pensando/ionic/ionic_txrx.c:608:3: warning:
 Variable 'done' is modified but its new value is never used.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   fffe3ae0ee84e25d2befe2ae59bc32aa2b6bc77b
commit: f9c00e2cf258d215a1ed2a7b2ae5b91ac2f29582 ionic: clean tx queue of unfinished requests
date:   4 months ago
:::::: branch date: 5 hours ago
:::::: commit date: 4 months ago
compiler: ia64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


cppcheck warnings: (new ones prefixed by >>)

>> drivers/net/ethernet/pensando/ionic/ionic_txrx.c:608:3: warning: Variable 'done' is modified but its new value is never used. [unreadVariable]
     done++;
     ^

# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f9c00e2cf258d215a1ed2a7b2ae5b91ac2f29582
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout f9c00e2cf258d215a1ed2a7b2ae5b91ac2f29582
vim +/done +608 drivers/net/ethernet/pensando/ionic/ionic_txrx.c

0f3154e6bcb3549 Shannon Nelson 2019-09-03  595  
f9c00e2cf258d21 Shannon Nelson 2020-03-27  596  void ionic_tx_empty(struct ionic_queue *q)
f9c00e2cf258d21 Shannon Nelson 2020-03-27  597  {
f9c00e2cf258d21 Shannon Nelson 2020-03-27  598  	struct ionic_desc_info *desc_info;
f9c00e2cf258d21 Shannon Nelson 2020-03-27  599  	int done = 0;
f9c00e2cf258d21 Shannon Nelson 2020-03-27  600  
f9c00e2cf258d21 Shannon Nelson 2020-03-27  601  	/* walk the not completed tx entries, if any */
f9c00e2cf258d21 Shannon Nelson 2020-03-27  602  	while (q->head != q->tail) {
f9c00e2cf258d21 Shannon Nelson 2020-03-27  603  		desc_info = q->tail;
f9c00e2cf258d21 Shannon Nelson 2020-03-27  604  		q->tail = desc_info->next;
f9c00e2cf258d21 Shannon Nelson 2020-03-27  605  		ionic_tx_clean(q, desc_info, NULL, desc_info->cb_arg);
f9c00e2cf258d21 Shannon Nelson 2020-03-27  606  		desc_info->cb = NULL;
f9c00e2cf258d21 Shannon Nelson 2020-03-27  607  		desc_info->cb_arg = NULL;
f9c00e2cf258d21 Shannon Nelson 2020-03-27 @608  		done++;
f9c00e2cf258d21 Shannon Nelson 2020-03-27  609  	}
f9c00e2cf258d21 Shannon Nelson 2020-03-27  610  }
f9c00e2cf258d21 Shannon Nelson 2020-03-27  611  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org