[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAE+NS360iKLoGxiiz8NmQqCp2Uge98Eehe4g2sn_N0e-E3DgyQ@mail.gmail.com>
Date: Thu, 6 Aug 2020 11:30:56 +0800
From: Gene Chen <gene.chen.richtek@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Lee Jones <lee.jones@...aro.org>,
Matthias Brugger <matthias.bgg@...il.com>, rafael@...nel.org,
gregkh@...uxfoundation.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
Gene Chen <gene_chen@...htek.com>, benjamin.chao@...iatek.com,
shufan_lee@...htek.com, cy_huang@...htek.com
Subject: Re: [PATCH 9/9] mfd: mt6360: Merge different sub-devices I2C read/write
Mark Brown <broonie@...nel.org> 於 2020年8月6日 週四 上午12:10寫道:
>
> On Wed, Aug 05, 2020 at 12:33:02AM +0800, Gene Chen wrote:
> > From: Gene Chen <gene_chen@...htek.com>
> >
> > Remove unuse register definition.
> > Merge different sub-devices I2C read/write functions into one Regmap,
> > because PMIC and LDO part need CRC bits for access protection.
>
> It's not clear why this isn't just done in the device regmap, there's
> exactly one user?
because I use one regmap to access 4 I2C devices,
I need change the regmap_bus struct to fit I2C read/write with CRC bit
Therefore, MFD reviewer suggests I can move the regmap api to regmap
folder such as regmap-ac97.c
Is it okay to apply this change?
Powered by blists - more mailing lists