linux-kernel - Re: [PATCH 2/3] dt-bindings: serial: Convert MXS auart to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200806140906.GA770620@bogus>
Date:   Thu, 6 Aug 2020 08:09:06 -0600
From:   Rob Herring <robh@...nel.org>
To:     Anson Huang <Anson.Huang@....com>
Cc:     galak@...eaurora.org, festevam@...il.com,
        linux-serial@...r.kernel.org, s.hauer@...gutronix.de,
        robh+dt@...nel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, Linux-imx@....com,
        kernel@...gutronix.de, shawnguo@...nel.org,
        gregkh@...uxfoundation.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: serial: Convert MXS auart to json-schema

On Wed, 05 Aug 2020 12:54:18 +0800, Anson Huang wrote:
> Convert the MXS auart binding to DT schema format using json-schema.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> ---
>  .../devicetree/bindings/serial/fsl-mxs-auart.txt   | 53 ------------
>  .../devicetree/bindings/serial/fsl-mxs-auart.yaml  | 93 ++++++++++++++++++++++
>  2 files changed, 93 insertions(+), 53 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/serial/fsl-mxs-auart.txt
>  create mode 100644 Documentation/devicetree/bindings/serial/fsl-mxs-auart.yaml
> 


My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx28-clock.example.dt.yaml: serial@...6a000: clocks: [[4294967295, 45]] is too short
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx28-clock.example.dt.yaml: serial@...6a000: compatible: Additional items are not allowed ('fsl,imx23-auart' was unexpected)
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx28-clock.example.dt.yaml: serial@...6a000: compatible: ['fsl,imx28-auart', 'fsl,imx23-auart'] is too long
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx28-clock.example.dt.yaml: serial@...6a000: 'dmas' is a required property
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx28-clock.example.dt.yaml: serial@...6a000: 'dma-names' is a required property
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx23-clock.example.dt.yaml: serial@...6c000: clocks: [[4294967295, 32]] is too short
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx23-clock.example.dt.yaml: serial@...6c000: 'dmas' is a required property
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/imx23-clock.example.dt.yaml: serial@...6c000: 'dma-names' is a required property


See https://patchwork.ozlabs.org/patch/1341077

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.