lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Aug 2020 09:54:08 +0800 From: Alex Shi <alex.shi@...ux.alibaba.com> To: Alexander Duyck <alexander.duyck@...il.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Mel Gorman <mgorman@...hsingularity.net>, Tejun Heo <tj@...nel.org>, Hugh Dickins <hughd@...gle.com>, Konstantin Khlebnikov <khlebnikov@...dex-team.ru>, Daniel Jordan <daniel.m.jordan@...cle.com>, Yang Shi <yang.shi@...ux.alibaba.com>, Matthew Wilcox <willy@...radead.org>, Johannes Weiner <hannes@...xchg.org>, kbuild test robot <lkp@...el.com>, linux-mm <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>, cgroups@...r.kernel.org, Shakeel Butt <shakeelb@...gle.com>, Joonsoo Kim <iamjoonsoo.kim@....com>, Wei Yang <richard.weiyang@...il.com>, "Kirill A. Shutemov" <kirill@...temov.name>, Rong Chen <rong.a.chen@...el.com>, Michal Hocko <mhocko@...nel.org>, Vladimir Davydov <vdavydov.dev@...il.com> Subject: Re: [PATCH v17 13/21] mm/lru: introduce TestClearPageLRU 在 2020/8/6 上午6:43, Alexander Duyck 写道: >> @@ -878,9 +877,8 @@ void release_pages(struct page **pages, int nr) >> spin_lock_irqsave(&locked_pgdat->lru_lock, flags); >> } >> >> - lruvec = mem_cgroup_page_lruvec(page, locked_pgdat); >> - VM_BUG_ON_PAGE(!PageLRU(page), page); >> __ClearPageLRU(page); >> + lruvec = mem_cgroup_page_lruvec(page, locked_pgdat); >> del_page_from_lru_list(page, lruvec, page_off_lru(page)); >> } >> > The more I look at this piece it seems like this change wasn't really > necessary. If anything it seems like it could catch potential bugs as > it was testing for the PageLRU flag before and then clearing it > manually anyway. In addition it doesn't reduce the critical path by > any significant amount so I am not sure these changes are providing > any benefit. Don't know hat kind of bug do you mean here, since the page is no one using, means no one could ClearPageLRU in other place, so if you like to keep the VM_BUG_ON_PAGE, that should be ok. Thanks! Alex
Powered by blists - more mailing lists