linux-kernel - Re: [PATCH -next] crypto: sa2ul: add Kconfig selects to fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce215b73-4c76-648f-f19d-46930e73a5ed@ti.com>
Date:   Thu, 6 Aug 2020 23:07:56 +0530
From:   "J, KEERTHY" <j-keerthy@...com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        David Miller <davem@...emloft.net>
CC:     Tero Kristo <t-kristo@...com>
Subject: Re: [PATCH -next] crypto: sa2ul: add Kconfig selects to fix build
 error



On 8/6/2020 9:24 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> sa2ul.c uses sha{1,256,512}_zero_message_hash, so select the
> Kconfig symbols that provide those, like other crypto drivers do.
> 
> Fixes this build error:
> 
> ld: drivers/crypto/sa2ul.o: in function `sa_sha_digest':
> sa2ul.c:(.text+0x2b25): undefined reference to `sha512_zero_message_hash'

Thanks for catching this.

Reviewed-by: Keerthy <j-keerthy@...com>

> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: Randy Dunlap <rdunlap@...radead.org> # 2020-07-29
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: linux-crypto@...r.kernel.org
> Cc: Tero Kristo <t-kristo@...com>
> Cc: Keerthy <j-keerthy@...com>
> ---
>   drivers/crypto/Kconfig |    3 +++
>   1 file changed, 3 insertions(+)
> 
> --- linux-next-20200806.orig/drivers/crypto/Kconfig
> +++ linux-next-20200806/drivers/crypto/Kconfig
> @@ -873,6 +873,9 @@ config CRYPTO_DEV_SA2UL
>   	select CRYPTO_AES
>   	select CRYPTO_AES_ARM64
>   	select CRYPTO_ALGAPI
> +	select CRYPTO_SHA1
> +	select CRYPTO_SHA256
> +	select CRYPTO_SHA512
>   	select HW_RANDOM
>   	select SG_SPLIT
>   	help
>