linux-kernel - Re: [PATCH] regulator: pwm: Do not print error on probe deferral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200806161557.GD6442@sirena.org.uk>
Date:   Thu, 6 Aug 2020 17:15:57 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: pwm: Do not print error on probe deferral

On Thu, Aug 06, 2020 at 05:55:15PM +0200, Thierry Reding wrote:

>  	if (IS_ERR(drvdata->enb_gpio)) {
>  		ret = PTR_ERR(drvdata->enb_gpio);
> -		dev_err(&pdev->dev, "Failed to get enable GPIO: %d\n", ret);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "Failed to get enable GPIO: %d\n", ret);

This will not provide any diagnostics if there's an issue with probe
deferral it'll be hard for people to figure out what's going on.  At
most lower the severity to dev_dbg() but don't totally remove the
logging.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)