linux-kernel - Re: [PATCH 5.7 0/6] 5.7.14-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 5 Aug 2020 17:09:44 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Marc Zyngier <maz@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Shuah Khan <shuah@...nel.org>, patches@...nelci.org,
        lkft-triage@...ts.linaro.org,
        Ben Hutchings <ben.hutchings@...ethink.co.uk>,
        linux- stable <stable@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Willy Tarreau <w@....eu>,
        Grygorii Strashko <grygorii.strashko@...com>
Subject: Re: [PATCH 5.7 0/6] 5.7.14-rc1 review

On 8/5/20 12:45 PM, Linus Torvalds wrote:
> On Wed, Aug 5, 2020 at 12:24 PM Guenter Roeck <linux@...ck-us.net> wrote:
>>
>> On 8/5/20 11:37 AM, Linus Torvalds wrote:
>>>
>>> Because the trivial fix would be something like the appended, which is
>>> the right thing to do anyway.
>>
>> Correct.
> 
> I'll take that as an Ack, and also remove the crazy reverse include
> from archrandom.h that most definitely shouldn't be there.
> 
Thanks, appreciated.

> It's now commit 585524081ecd ("random: random.h should include
> archrandom.h, not the other way around") in my tree, because a grep
> for "archrandom.h" shows that now the only place it exists is
> <linux/random.h> and a few files that cannot possibly affect arm64
> (because they are on x86 and powerpc, neither of which has that insane
> reverse include).
> 

I tried to build arm64 on current mainline, after reverting the dts
patches which cause the build failures there. Builds fine with both
gcc 7.4.0 and 9.3.0. 5.7.14-rc2 builds as well with both old and new
compilers. So hopefully we are fine.

Guenter