linux-kernel - Re: [PATCH v4] PCI: Reduce warnings on possible RW1C corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99c090fb-125c-42b7-1ea3-6840dcfada37@gmail.com>
Date:   Thu, 6 Aug 2020 11:34:53 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Mark Tomlinson <mark.tomlinson@...iedtelesis.co.nz>,
        ray.jui@...adcom.com, helgaas@...nel.org, sbranden@...adcom.com,
        lorenzo.pieralisi@....com, robh@...nel.org
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] PCI: Reduce warnings on possible RW1C corruption



On 8/5/2020 9:14 PM, Mark Tomlinson wrote:
> For hardware that only supports 32-bit writes to PCI there is the
> possibility of clearing RW1C (write-one-to-clear) bits. A rate-limited
> messages was introduced by fb2659230120, but rate-limiting is not the
> best choice here. Some devices may not show the warnings they should if
> another device has just produced a bunch of warnings. Also, the number
> of messages can be a nuisance on devices which are otherwise working
> fine.
> 
> This patch changes the ratelimit to a single warning per bus. This
> ensures no bus is 'starved' of emitting a warning and also that there
> isn't a continuous stream of warnings. It would be preferable to have a
> warning per device, but the pci_dev structure is not available here, and
> a lookup from devfn would be far too slow.
> 
> Suggested-by: Bjorn Helgaas <helgaas@...nel.org>
> Fixes: fb2659230120 ("PCI: Warn on possible RW1C corruption for sub-32 bit config writes")
> Signed-off-by: Mark Tomlinson <mark.tomlinson@...iedtelesis.co.nz>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian