linux-kernel - Re: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59bf7e04-a834-2728-dd2a-a2cd62a724a8@redhat.com>
Date:   Fri, 7 Aug 2020 11:59:29 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Alex Dewar <alex.dewar90@...il.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Parav Pandit <parav@...lanox.com>,
        Eli Cohen <eli@...lanox.com>,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks


On 2020/8/7 上午11:37, Jason Wang wrote:
>
> On 2020/8/7 上午3:18, Alex Dewar wrote:
>> In alloc_inout() in net/mlx5_vnet.c, there are a few places where memory
>> is allocated to *in and *out, but only the values of in and out are
>> null-checked (i.e. there is a missing dereference). Fix this.
>>
>> Addresses-Coverity: ("CID 1496603: (REVERSE_INULL)")
>> Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 
>> devices")
>> Signed-off-by: Alex Dewar <alex.dewar90@...il.com>
>
>
> Acked-by: Jason Wang <jasowang@...hat.com>


Colin posted something similar: [PATCH][next] vdpa/mlx5: fix memory 
allocation failure checks

And I think his fix is better since it prevent raw pointers to be freed.

Thanks