[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200807064729.GA981993@kroah.com>
Date: Fri, 7 Aug 2020 08:47:29 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Kees Cook <keescook@...omium.org>
Cc: linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
stable@...r.kernel.org, Jessica Yu <jeyu@...nel.org>,
Shuah Khan <shuah@...nel.org>,
Masahiro Yamada <masahiroy@...nel.org>,
linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 1/2] module: Correctly truncate sysfs sections output
On Thu, Aug 06, 2020 at 11:35:38PM -0700, Kees Cook wrote:
> The only-root-readable /sys/module/$module/sections/$section files
> did not truncate their output to the available buffer size. While most
> paths into the kernfs read handlers end up using PAGE_SIZE buffers,
> it's possible to get there through other paths (e.g. splice, sendfile).
> Actually limit the output to the "count" passed into the read function,
> and report it back correctly. *sigh*
Ugh, never thought about that...
Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Powered by blists - more mailing lists