linux-kernel - RE: [PATCH] ASoC: amd: Replacing component->name with codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR12MB4292C19FB56A631E63FB85E7E7490@BY5PR12MB4292.namprd12.prod.outlook.com>
Date:   Fri, 7 Aug 2020 08:09:35 +0000
From:   "RAVULAPATI, VISHNU VARDHAN RAO" 
        <Vishnuvardhanrao.Ravulapati@....com>
To:     Mark Brown <broonie@...nel.org>
CC:     Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        YueHaibing <yuehaibing@...wei.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ASoC: amd: Replacing component->name with codec_dai->name



-----Original Message-----
From: Mark Brown <broonie@...nel.org> 
Sent: Thursday, August 6, 2020 4:59 PM
To: RAVULAPATI, VISHNU VARDHAN RAO <Vishnuvardhanrao.Ravulapati@....com>
Cc: Liam Girdwood <lgirdwood@...il.com>; Jaroslav Kysela <perex@...ex.cz>; Takashi Iwai <tiwai@...e.com>; Agrawal, Akshu <Akshu.Agrawal@....com>; Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>; YueHaibing <yuehaibing@...wei.com>; moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM... <alsa-devel@...a-project.org>; open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: amd: Replacing component->name with codec_dai->name

On Thu, Aug 06, 2020 at 03:44:12PM +0530, Ravulapati Vishnu vardhan rao wrote:

> Replacing string compare with codec_dai->name instead of comparing 
> with codec_dai->component->name in hw_params.

>Why?

Here the component name for codec RT1015 is "i2c-10EC5682:00" and will never be "rt1015-aif1"
As it is codec-dai->name so the strcmp always compares and fails to set the sysclk,pll,bratio of expected codec-dai

Thanks,
Vishnu