lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Aug 2020 05:35:28 -0300 From: "Daniel W. S. Almeida" <dwlsalmeida@...il.com> To: Jernej Skrabec <jernej.skrabec@...l.net>, Maxime Ripard <mripard@...nel.org>, Chen-Yu Tsai <wens@...e.org> Cc: skhan@...uxfoundation.org, "Daniel W. S. Almeida" <dwlsalmeida@...il.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: [PATCH 01/20] media: sunxi: sun8i-rotate.c: remove useless error message From: "Daniel W. S. Almeida" <dwlsalmeida@...il.com> This fixes the following coccinelle report: drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c:751:2-9: line 751 is redundant because platform_get_irq() already prints an error By removing the useless call to dev_err() Found using - Coccinelle (http://coccinelle.lip6.fr) Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@...il.com> --- drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c b/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c index 94f505d3cbad..3f81dd17755c 100644 --- a/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c +++ b/drivers/media/platform/sunxi/sun8i-rotate/sun8i_rotate.c @@ -747,11 +747,8 @@ static int rotate_probe(struct platform_device *pdev) dev->dev = &pdev->dev; irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - dev_err(dev->dev, "Failed to get IRQ\n"); - + if (irq <= 0) return irq; - } ret = devm_request_irq(dev->dev, irq, rotate_irq, 0, dev_name(dev->dev), dev); -- 2.28.0
Powered by blists - more mailing lists