linux-kernel - RE: [PATCH net-next v1] hinic: fix strncpy output truncated compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7a4fcf12a4e4d179e2fae8ffb44f992@AcuMS.aculab.com>
Date:   Fri, 7 Aug 2020 09:32:07 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Luo bin' <luobin9@...wei.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "luoxianjun@...wei.com" <luoxianjun@...wei.com>,
        "yin.yinshi@...wei.com" <yin.yinshi@...wei.com>,
        "cloud.wangxiaoyun@...wei.com" <cloud.wangxiaoyun@...wei.com>,
        "chiqijun@...wei.com" <chiqijun@...wei.com>
Subject: RE: [PATCH net-next v1] hinic: fix strncpy output truncated compile
 warnings

From: Luo bin
> Sent: 07 August 2020 03:09
> 
> fix the compile warnings of 'strncpy' output truncated before
> terminating nul copying N bytes from a string of the same length
> 
> Signed-off-by: Luo bin <luobin9@...wei.com>
> Reported-by: kernel test robot <lkp@...el.com>
> ---
> V0~V1:
> - use the strlen()+1 pattern consistently
> 
>  drivers/net/ethernet/huawei/hinic/hinic_devlink.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_devlink.c
> b/drivers/net/ethernet/huawei/hinic/hinic_devlink.c
> index c6adc776f3c8..1ec88ebf81d6 100644
> --- a/drivers/net/ethernet/huawei/hinic/hinic_devlink.c
> +++ b/drivers/net/ethernet/huawei/hinic/hinic_devlink.c
> @@ -342,9 +342,9 @@ static int chip_fault_show(struct devlink_fmsg *fmsg,
> 
>  	level = event->event.chip.err_level;
>  	if (level < FAULT_LEVEL_MAX)
> -		strncpy(level_str, fault_level[level], strlen(fault_level[level]));
> +		strncpy(level_str, fault_level[level], strlen(fault_level[level]) + 1);

Have you even considered what that code is actually doing?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)