linux-kernel - arch/sh/include/asm/bitops-op32.h:39:17: sparse: sparse: context imbalance in 'mptcp_sk_clone'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 7 Aug 2020 17:54:23 +0800
From:   kernel test robot <lkp@...el.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>
Subject: arch/sh/include/asm/bitops-op32.h:39:17: sparse: sparse: context
 imbalance in 'mptcp_sk_clone' - unexpected unlock

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   86cfccb66937dd6cbf26ed619958b9e587e6a115
commit: 2c5ebd001d4f0c64a2dfda94eb1d9b31a8863c8d mptcp: refactor token container
date:   6 weeks ago
config: sh-randconfig-s031-20200807 (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.2-118-ge1578773-dirty
        git checkout 2c5ebd001d4f0c64a2dfda94eb1d9b31a8863c8d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)

   net/mptcp/protocol.c: note: in included file (through arch/sh/include/asm/bitops.h, include/linux/bitops.h, include/linux/kernel.h):
>> arch/sh/include/asm/bitops-op32.h:39:17: sparse: sparse: context imbalance in 'mptcp_sk_clone' - unexpected unlock

vim +/mptcp_sk_clone +39 arch/sh/include/asm/bitops-op32.h

0d5bbe0bc2583c Paul Mundt      2008-11-25  35  
0d5bbe0bc2583c Paul Mundt      2008-11-25  36  static inline void __clear_bit(int nr, volatile unsigned long *addr)
0d5bbe0bc2583c Paul Mundt      2008-11-25  37  {
e3c0f6f3fbdaca Masahiro Yamada 2019-07-23  38  	if (__builtin_constant_p(nr)) {
0d5bbe0bc2583c Paul Mundt      2008-11-25 @39  		__asm__ __volatile__ (
0d5bbe0bc2583c Paul Mundt      2008-11-25  40  			"bclr.b %1, @(%O2,%0)		! __clear_bit\n\t"
0d5bbe0bc2583c Paul Mundt      2008-11-25  41  			: "+r" (addr)
0d5bbe0bc2583c Paul Mundt      2008-11-25  42  			: "i" (BYTE_OFFSET(nr)),
0d5bbe0bc2583c Paul Mundt      2008-11-25  43  			  "i" (BYTE_NUMBER(nr))
0d5bbe0bc2583c Paul Mundt      2008-11-25  44  			: "t", "memory"
0d5bbe0bc2583c Paul Mundt      2008-11-25  45  		);
0d5bbe0bc2583c Paul Mundt      2008-11-25  46  	} else {
0d5bbe0bc2583c Paul Mundt      2008-11-25  47  		unsigned long mask = BIT_MASK(nr);
0d5bbe0bc2583c Paul Mundt      2008-11-25  48  		unsigned long *p = ((unsigned long *)addr) + BIT_WORD(nr);
0d5bbe0bc2583c Paul Mundt      2008-11-25  49  
0d5bbe0bc2583c Paul Mundt      2008-11-25  50  		*p &= ~mask;
0d5bbe0bc2583c Paul Mundt      2008-11-25  51  	}
0d5bbe0bc2583c Paul Mundt      2008-11-25  52  }
0d5bbe0bc2583c Paul Mundt      2008-11-25  53  

:::::: The code at line 39 was first introduced by commit
:::::: 0d5bbe0bc2583c4dc06ea00adccf07c3acd1481d sh: Provide optimized non-atomic bitops for SH-2A.

:::::: TO: Paul Mundt <lethal@...ux-sh.org>
:::::: CC: Paul Mundt <lethal@...ux-sh.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (25875 bytes)