lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Aug 2020 10:32:11 +0900 From: Chanwoo Choi <cw00.choi@...sung.com> To: Sylwester Nawrocki <s.nawrocki@...sung.com>, linux-clk@...r.kernel.org Cc: tomasz.figa@...il.com, sboyd@...nel.org, mturquette@...libre.com, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org, b.zolnierkie@...sung.com, m.szyprowski@...sung.com Subject: Re: [PATCH] clk: samsung: Prevent potential endless loop in the PLL set_rate ops Hi Sylwester, On 8/7/20 1:06 AM, Sylwester Nawrocki wrote: > In the .set_rate callback for some PLLs there is a loop polling state > of the PLL lock bit and it may become an endless loop when something > goes wrong with the PLL. For some PLLs there is already (duplicated) > code for polling with a timeout. This patch refactors that code a bit > and moves it to a common helper function which is then used > in .set_rate callbacks for all the PLLs. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@...sung.com> > --- > drivers/clk/samsung/clk-pll.c | 94 +++++++++++++---------------------- > 1 file changed, 35 insertions(+), 59 deletions(-) > (snip) It fix the infinite loop and unify the duplicate code. It looks good to me. Thanks. Acked-by: Chanwoo Choi <cw00.choi@...sung.com> -- Best Regards, Chanwoo Choi Samsung Electronics
Powered by blists - more mailing lists