linux-kernel - Re: [PATCH 03/10] mm/hugetlb: use list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200807125327.GN14854@MiWiFi-R3L-srv>
Date:   Fri, 7 Aug 2020 20:53:27 +0800
From:   Baoquan He <bhe@...hat.com>
To:     Wei Yang <richard.weiyang@...ux.alibaba.com>
Cc:     mike.kravetz@...cle.com, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/10] mm/hugetlb: use list_splice to merge two list at
 once

On 08/07/20 at 05:12pm, Wei Yang wrote:
> Instead of add allocated file_region one by one to region_cache, we
> could use list_splice to merge two list at once.
> 
> Also we know the number of entries in the list, increase the number
> directly.
> 
> Signed-off-by: Wei Yang <richard.weiyang@...ux.alibaba.com>
> ---
>  mm/hugetlb.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 0a2f3851b828..929256c130f9 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -443,11 +443,8 @@ static int allocate_file_region_entries(struct resv_map *resv,
>  
>  		spin_lock(&resv->lock);
>  
> -		list_for_each_entry_safe(rg, trg, &allocated_regions, link) {
> -			list_del(&rg->link);
> -			list_add(&rg->link, &resv->region_cache);
> -			resv->region_cache_count++;
> -		}
> +		list_splice(&allocated_regions, &resv->region_cache);
> +		resv->region_cache_count += to_allocate;

Looks good to me.

Reviewed-by: Baoquan He <bhe@...hat.com>

>  	}
>  
>  	return 0;
> -- 
> 2.20.1 (Apple Git-117)
> 
>