linux-kernel - Re: [PATCH 2/5] spi: stm32: fix fifo threshold level in case of short transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200807132722.GJ5435@sirena.org.uk>
Date:   Fri, 7 Aug 2020 14:27:22 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Alain Volmat <alain.volmat@...com>
Cc:     amelie.delaunay@...com, mcoquelin.stm32@...il.com,
        alexandre.torgue@...com, linux-spi@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        fabrice.gasnier@...com
Subject: Re: [PATCH 2/5] spi: stm32: fix fifo threshold level in case of
 short transfer

On Fri, Aug 07, 2020 at 03:21:22PM +0200, Alain Volmat wrote:

> +	/* data_packet should not exceed transfer length */
> +	packet = (half_fifo > xfer_len) ? xfer_len : half_fifo;

Please write normal conditional statements to improve legibility.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)