linux-kernel - Re: [PATCH RFC leds + net-next v4 0/2] Add support for LEDs on Marvell PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200807132920.GB2028541@lunn.ch>
Date:   Fri, 7 Aug 2020 15:29:20 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Pavel Machek <pavel@....cz>
Cc:     Marek Behún <marek.behun@....cz>,
        netdev@...r.kernel.org, linux-leds@...r.kernel.org,
        jacek.anaszewski@...il.com, Dan Murphy <dmurphy@...com>,
        Ondřej Jirman <megous@...ous.com>,
        Russell King <linux@...linux.org.uk>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Gregory Clement <gregory.clement@...tlin.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC leds + net-next v4 0/2] Add support for LEDs on
 Marvell PHYs

> > And no, I don't want phydev name there.
> 
> Ummm. Can we get little more explanation on that? I fear that LED
> device renaming will be tricky and phydev would work around that
> nicely.

Hi Pavel

The phydev name is not particularly nice:

!mdio-mux!mdio@...witch@...dio:00
!mdio-mux!mdio@...witch@...dio:01
!mdio-mux!mdio@...witch@...dio:02
!mdio-mux!mdio@...witch@...dio:00
!mdio-mux!mdio@...witch@...dio:01
!mdio-mux!mdio@...witch@...dio:02
!mdio-mux!mdio@...witch@...dio:00
!mdio-mux!mdio@...witch@...dio:01
!mdio-mux!mdio@...witch@...dio:02
400d0000.ethernet-1:00
400d0000.ethernet-1:01
fixed-0:00

The interface name are:

1: lo:
2: eth0:
3: eth1:
4: lan0@...1:
5: lan1@...1:
6: lan2@...1:
7: lan3@...1:
8: lan4@...1:
9: lan5@...1:
10: lan6@...1:
11: lan7@...1:
12: lan8@...1:
13: optical3@...1:
14: optical4@...1:

You could make a good guess at matching to two together, but it is
error prone. Phys are low level things which the user is not really
involved in. They interact with interface names. ethtool, ip, etc, all
use interface names. In fact, i don't know of any tool which uses
phydev names.

	 Andrew