linux-kernel - Re: [PATCH V2 4/4] dt-bindings: lpspi: New property in document DT bindings for LPSPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 7 Aug 2020 08:51:00 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Clark Wang <xiaoning.wang@....com>
Cc:     Mark Brown <broonie@...nel.org>, Anson Huang <Anson.Huang@....com>,
        linux-spi <linux-spi@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 4/4] dt-bindings: lpspi: New property in document DT
 bindings for LPSPI

On Fri, Jul 31, 2020 at 11:38 AM Rob Herring <robh+dt@...nel.org> wrote:
>
> On Sun, Jul 26, 2020 at 9:15 PM Clark Wang <xiaoning.wang@....com> wrote:
> >
> > Add "fsl,spi-only-use-cs1-sel" to fit i.MX8DXL-EVK.
> > Spi common code does not support use of CS signals discontinuously.
> > It only uses CS1 without using CS0. So, add this property to re-config
> > chipselect value.
> >
> > Signed-off-by: Clark Wang <xiaoning.wang@....com>
> > ---
> > Changes:
> > V2:
> >  - New patch added in the v2 patchset.
> > ---
> >  Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
> > index 143b94a1883a..22882e769e26 100644
> > --- a/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml
> > @@ -34,6 +34,12 @@ properties:
> >        - const: per
> >        - const: ipg
> >
> > +  fsl,spi-only-use-cs1-sel:
> > +    description:
> > +      spi common code does not support use of CS signals discontinuously.
> > +      i.MX8DXL-EVK board only uses CS1 without using CS0. Therefore, add
> > +      this property to re-config the chipselect value in the LPSPI driver.
>
> This breaks linux-next and you didn't test with 'make dt_binding_check':
>
> /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml:
> properties:fsl,spi-only-use-cs1-sel: {'description': 'spi common code
> does not support use of CS signals discontinuously. i.MX8DXL-EVK board
> only uses CS1 without using CS0. Therefore, add this property to
> re-config the chipselect value in the LPSPI driver.'} is not valid
> under any of the given schemas (Possible causes of the failure):
>  /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml:
> properties:fsl,spi-only-use-cs1-sel: 'not' is a required property
>
> The problem is you need a type definition for a vendor specific
> property. In this case 'type: boolean'.

Ping! And now Linus' tree is broken. If you can't be bothered to fix
this, perhaps it should be reverted.

Rob