linux-kernel - Re: [PATCH] drm/panfrost: perfcnt: fix ref count leak in panfrost_perfcnt_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqKvrKU6RScJSsHFNn7GHx0N9XCdZmNupRGDqg4h0UKV9w@mail.gmail.com>
Date:   Fri, 7 Aug 2020 10:41:43 -0600
From:   Rob Herring <robh@...nel.org>
To:     Navid Emamdoost <navid.emamdoost@...il.com>
Cc:     Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        Steven Price <steven.price@....com>,
        Alyssa Rosenzweig <alyssa.rosenzweig@...labora.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Navid Emamdoost <emamd001@....edu>, wu000273@....edu,
        kjlu@....edu, mccamant@...umn.edu
Subject: Re: [PATCH] drm/panfrost: perfcnt: fix ref count leak in panfrost_perfcnt_enable_locked

On Sun, Jun 14, 2020 at 12:36 AM Navid Emamdoost
<navid.emamdoost@...il.com> wrote:
>
> in panfrost_perfcnt_enable_locked, pm_runtime_get_sync is called which
> increments the counter even in case of failure, leading to incorrect
> ref count. In case of failure, decrement the ref count before returning.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>
> ---
>  drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

Applied.

Rob