linux-kernel - Re: [PATCH v2] hwmon/pmbus: use simple i2c probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200807182306.032376e5@heffalump.sk2.org>
Date:   Fri, 7 Aug 2020 18:23:06 +0200
From:   Stephen Kitt <steve@....org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hwmon/pmbus: use simple i2c probe function

On Fri, 7 Aug 2020 08:23:29 -0700, Guenter Roeck <linux@...ck-us.net> wrote:
> On 8/7/20 12:45 AM, Stephen Kitt wrote:
> > pmbus_do_probe doesn't use the id information provided in its second
> > argument, so this can be removed, which then allows using the
> > single-parameter i2c probe function ("probe_new") for probes.
> > 
> > This avoids scanning the identifier tables during probes.
> > 
> > Drivers which didn't use the id are converted as-is; drivers which did
> > are modified as follows:
> > 
> > * if the information in i2c_client is sufficient, that's used instead
> >   (client->name);
> > * configured v. probed comparisons are performed by comparing the
> >   configured name to the detected name, instead of the ids; this
> >   involves strcmp but is still cheaper than comparing all the device
> >   names when scanning the tables;
> > * anything else is handled by calling i2c_match_id() with the same
> >   level of error-handling (if any) as before.
> > 
> > Signed-off-by: Stephen Kitt <steve@....org>  
> 
> Please also update the documentation.
> 
> Documentation/hwmon/pmbus-core.rst:  int pmbus_do_probe(struct i2c_client
> *client, const struct i2c_device_id *id, Documentation/hwmon/pmbus.rst:
> return pmbus_do_probe(client, id, &ds1200_info);

Aargh, I usually *start* from the documentation, but I didn’t think to check
in this case.

> Also, please fix the checkpatch issue reported by Wolfram.

Will do, v3 on its way.

Thanks for the reviews!

Regards,

Stephen

Content of type "application/pgp-signature" skipped