lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 7 Aug 2020 11:24:35 +0800
From:   Alex Shi <>
To:     Alexander Duyck <>
Cc:     Andrew Morton <>,
        Mel Gorman <>,
        Tejun Heo <>, Hugh Dickins <>,
        Konstantin Khlebnikov <>,
        Daniel Jordan <>,
        Yang Shi <>,
        Matthew Wilcox <>,
        Johannes Weiner <>,
        kbuild test robot <>,
        linux-mm <>,
        LKML <>,,
        Shakeel Butt <>,
        Joonsoo Kim <>,
        Wei Yang <>,
        "Kirill A. Shutemov" <>,
        Rong Chen <>
Subject: Re: [PATCH v17 14/21] mm/compaction: do page isolation first in

在 2020/8/7 上午2:38, Alexander Duyck 写道:
>> +
>>  isolate_abort:
>>         if (locked)
>>                 spin_unlock_irqrestore(&pgdat->lru_lock, flags);
>> +       if (page) {
>> +               SetPageLRU(page);
>> +               put_page(page);
>> +       }
>>         /*
>>          * Updated the cached scanner pfn once the pageblock has been scanned
> We should probably be calling SetPageLRU before we release the lru
> lock instead of before. It might make sense to just call it before we
> get here, similar to how you did in the isolate_fail_put case a few
> lines later. Otherwise this seems to violate the rules you had set up
> earlier where we were only going to be setting the LRU bit while
> holding the LRU lock.

Hi Alex,

Set out of lock here should be fine. I never said we must set the bit in locking.
And this page is get by get_page_unless_zero(), no warry on release.


Powered by blists - more mailing lists