lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 8 Aug 2020 13:31:58 +0300
From:   Andy Shevchenko <>
To:     Crt Mori <>
Cc:     Jonathan Cameron <>,
        linux-iio <>,
        Linux Kernel Mailing List <>
Subject: Re: [PATCH v3 1/2] iio:temperature:mlx90632: Reduce number of equal calulcations

On Sat, Aug 8, 2020 at 2:22 AM Crt Mori <> wrote:
> TAdut4 was calculated each iteration although it did not change. In light
> of near future additions of the Extended range DSP calculations, this
> function refactoring will help reduce unrelated changes in that series as
> well as reduce the number of new functions needed.

I see you provided a helper for this calculus, but I think we may
reduce a lot of churn if you do the following:
- introduce helper and convert one/current user (no functional change!)
- do what you did in this patch, but it will move less LOCs
- do what you have done in the next one using the helper

With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists