linux-kernel - Re: [PATCH] docs: Fix function name trailing double-()s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 8 Aug 2020 08:15:57 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Jonathan Corbet <corbet@....net>, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH] docs: Fix function name trailing double-()s

On Fri, Aug 07, 2020 at 11:49:59PM -0700, Kees Cook wrote:
> I noticed a double-() after a function name in deprecated.rst today. Fix
> that one and two others in the Documentation/ tree.
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>

For the RCU hunk:

Acked-by: Paul E. McKenney <paulmck@...nel.org>

Or I could take the Documentation/RCU/lockdep.rst portion, if you
would prefer.

> ---
>  Documentation/RCU/lockdep.rst                           | 2 +-
>  Documentation/process/deprecated.rst                    | 2 +-
>  Documentation/translations/it_IT/process/deprecated.rst | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/RCU/lockdep.rst b/Documentation/RCU/lockdep.rst
> index f1fc8ae3846a..cc860a0c296b 100644
> --- a/Documentation/RCU/lockdep.rst
> +++ b/Documentation/RCU/lockdep.rst
> @@ -49,7 +49,7 @@ checking of rcu_dereference() primitives:
>  		is invoked by both RCU-sched readers and updaters.
>  	srcu_dereference_check(p, c):
>  		Use explicit check expression "c" along with
> -		srcu_read_lock_held()().  This is useful in code that
> +		srcu_read_lock_held().  This is useful in code that
>  		is invoked by both SRCU readers and updaters.
>  	rcu_dereference_raw(p):
>  		Don't check.  (Use sparingly, if at all.)
> diff --git a/Documentation/process/deprecated.rst b/Documentation/process/deprecated.rst
> index 4a9aa4f0681e..918e32d76fc4 100644
> --- a/Documentation/process/deprecated.rst
> +++ b/Documentation/process/deprecated.rst
> @@ -142,7 +142,7 @@ only NUL-terminated strings. The safe replacement is strscpy().
>  (Users of strscpy() still needing NUL-padding should instead
>  use strscpy_pad().)
>  
> -If a caller is using non-NUL-terminated strings, strncpy()() can
> +If a caller is using non-NUL-terminated strings, strncpy() can
>  still be used, but destinations should be marked with the `__nonstring
>  <https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html>`_
>  attribute to avoid future compiler warnings.
> diff --git a/Documentation/translations/it_IT/process/deprecated.rst b/Documentation/translations/it_IT/process/deprecated.rst
> index e108eaf82cf6..a642ff3fdc8b 100644
> --- a/Documentation/translations/it_IT/process/deprecated.rst
> +++ b/Documentation/translations/it_IT/process/deprecated.rst
> @@ -130,7 +130,7 @@ chi usa solo stringe terminate. La versione sicura da usare è
>  strscpy(). (chi usa strscpy() e necessita di estendere la
>  terminazione con NUL deve aggiungere una chiamata a memset())
>  
> -Se il chiamate no usa stringhe terminate con NUL, allore strncpy()()
> +Se il chiamate no usa stringhe terminate con NUL, allore strncpy()
>  può continuare ad essere usata, ma i buffer di destinazione devono essere
>  marchiati con l'attributo `__nonstring <https://gcc.gnu.org/onlinedocs/gcc/Common-Variable-Attributes.html>`_
>  per evitare avvisi durante la compilazione.
> -- 
> 2.25.1
> 
> 
> -- 
> Kees Cook