linux-kernel - arch/powerpc/kexec/crash.c:200 crash_kexec_secondary() warn: inconsistent returns 'flags'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 8 Aug 2020 08:14:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     Christophe Leroy <christophe.leroy@....fr>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Michael Ellerman <mpe@...erman.id.au>
Subject: arch/powerpc/kexec/crash.c:200 crash_kexec_secondary() warn:
 inconsistent returns 'flags'.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   30185b69a2d533c4ba6ca926b8390ce7de495e29
commit: 793b08e2efff3ec020c5c5861d00ed394fcdd488 powerpc/kexec: Move kexec files into a dedicated subdir.
date:   9 months ago
config: powerpc-randconfig-m031-20200808 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

smatch warnings:
arch/powerpc/kexec/crash.c:200 crash_kexec_secondary() warn: inconsistent returns 'flags'.

vim +/flags +200 arch/powerpc/kexec/crash.c

c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  178  
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  179  /*
9b00ac06978c54 arch/powerpc/kernel/crash.c Anton Blanchard 2011-11-30  180   * This function will be called by secondary cpus.
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  181   */
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  182  void crash_kexec_secondary(struct pt_regs *regs)
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  183  {
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  184  	unsigned long flags;
549e88a134b3b3 arch/powerpc/kernel/crash.c Anton Blanchard 2011-11-30  185  	int msecs = SECONDARY_TIMEOUT;
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  186  
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  187  	local_irq_save(flags);
9b00ac06978c54 arch/powerpc/kernel/crash.c Anton Blanchard 2011-11-30  188  
549e88a134b3b3 arch/powerpc/kernel/crash.c Anton Blanchard 2011-11-30  189  	/* Wait for the primary crash CPU to signal its progress */
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  190  	while (crashing_cpu < 0) {
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  191  		if (--msecs < 0) {
9b00ac06978c54 arch/powerpc/kernel/crash.c Anton Blanchard 2011-11-30  192  			/* No response, kdump image may not have been loaded */
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  193  			local_irq_restore(flags);
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  194  			return;
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  195  		}
9b00ac06978c54 arch/powerpc/kernel/crash.c Anton Blanchard 2011-11-30  196  
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  197  		mdelay(1);
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  198  	}
9b00ac06978c54 arch/powerpc/kernel/crash.c Anton Blanchard 2011-11-30  199  
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23 @200  	crash_ipi_callback(regs);
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  201  }
c0ce7d0886cf0c arch/powerpc/kernel/crash.c David Wilder    2006-06-23  202  

:::::: The code at line 200 was first introduced by commit
:::::: c0ce7d0886cf0c2579c604eac41a7e125bc0e96d [POWERPC] Add the use of the firmware soft-reset-nmi to kdump.

:::::: TO: David Wilder <dwilder@...ibm.com>
:::::: CC: Paul Mackerras <paulus@...ba.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (23946 bytes)