linux-kernel - [PATCH] mmc: block: fix memdup.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2008091720080.2450@hadrien>
Date:   Sun, 9 Aug 2020 17:21:37 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Tomas Winkler <tomas.winkler@...el.com>
cc:     kbuild-all@...ts.01.org, Zhou Furong <furong.zhou@...el.com>,
        Alexander Usyskin <alexander.usyskin@...el.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] mmc: block: fix memdup.cocci warnings

From: kernel test robot <lkp@...el.com>

 Use kmemdup rather than duplicating its implementation

Generated by: scripts/coccinelle/api/memdup.cocci

Fixes: 68083eebfb0a ("mmc: block: register RPMB partition with the RPMB subsystem")
CC: Tomas Winkler <tomas.winkler@...el.com>
Signed-off-by: kernel test robot <lkp@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>
---

tree:   https://github.com/intel/linux-intel-lts.git 5.4/preempt-rt
head:   64f494c08613ebb24a83b69223e7f90e8b7ce956
commit: 68083eebfb0a008e9bec30cefb2260f0543ed5ec [97/9103] mmc: block: register RPMB partition with the RPMB subsystem
:::::: branch date: 4 days ago
:::::: commit date: 9 months ago

 block.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -1270,11 +1270,10 @@ static int mmc_blk_rpmb_set_dev_id(struc
 {
 	char *id;

-	id = kmalloc(sizeof(card->raw_cid), GFP_KERNEL);
+	id = kmemdup(card->raw_cid, sizeof(card->raw_cid), GFP_KERNEL);
 	if (!id)
 		return -ENOMEM;

-	memcpy(id, card->raw_cid, sizeof(card->raw_cid));
 	ops->dev_id = id;
 	ops->dev_id_len = sizeof(card->raw_cid);