linux-kernel - Re: [PATCH for-fixes] MIPS: Loongson64: Do not override watch and ejtag feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 9 Aug 2020 09:28:42 +0800
From:   Huacai Chen <chenhc@...ote.com>
To:     Jiaxun Yang <jiaxun.yang@...goat.com>
Cc:     "open list:MIPS" <linux-mips@...r.kernel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH for-fixes] MIPS: Loongson64: Do not override watch and
 ejtag feature

Reviewed-by: Huacai Chen <chenhc@...ote.com>

On Sat, Aug 8, 2020 at 8:33 PM Jiaxun Yang <jiaxun.yang@...goat.com> wrote:
>
> Do not override ejtag feature to 0 as Loongson 3A1000+ do have ejtag.
> For watch, as KVM emulated CPU doesn't have watch feature, we should
> not enable it unconditionally.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@...goat.com>
> ---
> This patch should go into mips-fixes tree as watch feature is blocking
> KVM guest boot in some cases.
> ---
>  arch/mips/include/asm/mach-loongson64/cpu-feature-overrides.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/include/asm/mach-loongson64/cpu-feature-overrides.h b/arch/mips/include/asm/mach-loongson64/cpu-feature-overrides.h
> index b6e9c99b85a5..eb181224eb4c 100644
> --- a/arch/mips/include/asm/mach-loongson64/cpu-feature-overrides.h
> +++ b/arch/mips/include/asm/mach-loongson64/cpu-feature-overrides.h
> @@ -26,7 +26,6 @@
>  #define cpu_has_counter                1
>  #define cpu_has_dc_aliases     (PAGE_SIZE < 0x4000)
>  #define cpu_has_divec          0
> -#define cpu_has_ejtag          0
>  #define cpu_has_inclusive_pcaches      1
>  #define cpu_has_llsc           1
>  #define cpu_has_mcheck         0
> @@ -42,7 +41,6 @@
>  #define cpu_has_veic           0
>  #define cpu_has_vint           0
>  #define cpu_has_vtag_icache    0
> -#define cpu_has_watch          1
>  #define cpu_has_wsbh           1
>  #define cpu_has_ic_fills_f_dc  1
>  #define cpu_hwrena_impl_bits   0xc0000000
> --
> 2.28.0.rc1
>