lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 9 Aug 2020 22:29:32 +0100 From: "Lad, Prabhakar" <prabhakar.csengg@...il.com> To: Laurent Pinchart <laurent.pinchart@...asonboard.com> Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, Geert Uytterhoeven <geert+renesas@...der.be>, Kieran Bingham <kieran.bingham+renesas@...asonboard.com>, David Airlie <airlied@...ux.ie>, Rob Herring <robh+dt@...nel.org>, Magnus Damm <magnus.damm@...il.com>, Daniel Vetter <daniel@...ll.ch>, dri-devel@...ts.freedesktop.org, Linux-Renesas <linux-renesas-soc@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org> Subject: Re: [PATCH 6/7] ARM: dts: r8a7742: Add LVDS support Hi Laurent, Thank you for the review. On Sat, Aug 8, 2020 at 10:13 PM Laurent Pinchart <laurent.pinchart@...asonboard.com> wrote: > > Hi Prabhakar, > > Thank you for the patch. > > On Fri, Aug 07, 2020 at 06:49:53PM +0100, Lad Prabhakar wrote: > > Add LVDS encoder node to r8a7742 SoC DT. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com> > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@...renesas.com> > > --- > > arch/arm/boot/dts/r8a7742.dtsi | 54 ++++++++++++++++++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r8a7742.dtsi b/arch/arm/boot/dts/r8a7742.dtsi > > index a979a4b3de61..a7e66220d63a 100644 > > --- a/arch/arm/boot/dts/r8a7742.dtsi > > +++ b/arch/arm/boot/dts/r8a7742.dtsi > > @@ -1534,11 +1534,65 @@ > > port@1 { > > reg = <1>; > > du_out_lvds0: endpoint { > > + remote-endpoint = <&lvds0_in>; > > }; > > }; > > port@2 { > > reg = <2>; > > du_out_lvds1: endpoint { > > + remote-endpoint = <&lvds1_in>; > > + }; > > + }; > > + }; > > + }; > > + > > + lvds0: lvds@...90000 { > > + compatible = "renesas,r8a7742-lvds"; > > + reg = <0 0xfeb90000 0 0x1c>; > > Isn't 0x14 enough for the size ? 0x1c won't hurt though. Same comment > below. > Agreed, 0x1c comes from Gen-3 manuals. Cheers, Prabhakar > With or without this addressed, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com> > > > + clocks = <&cpg CPG_MOD 726>; > > + power-domains = <&sysc R8A7742_PD_ALWAYS_ON>; > > + resets = <&cpg 726>; > > + status = "disabled"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + lvds0_in: endpoint { > > + remote-endpoint = <&du_out_lvds0>; > > + }; > > + }; > > + port@1 { > > + reg = <1>; > > + lvds0_out: endpoint { > > + }; > > + }; > > + }; > > + }; > > + > > + lvds1: lvds@...94000 { > > + compatible = "renesas,r8a7742-lvds"; > > + reg = <0 0xfeb94000 0 0x1c>; > > + clocks = <&cpg CPG_MOD 725>; > > + power-domains = <&sysc R8A7742_PD_ALWAYS_ON>; > > + resets = <&cpg 725>; > > + status = "disabled"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + lvds1_in: endpoint { > > + remote-endpoint = <&du_out_lvds1>; > > + }; > > + }; > > + port@1 { > > + reg = <1>; > > + lvds1_out: endpoint { > > }; > > }; > > }; > > -- > Regards, > > Laurent Pinchart
Powered by blists - more mailing lists