linux-kernel - Re: [PATCH 3/7] dyndbg: select ZPOOL in Kconfig.debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e5c90bf-eb04-4b63-2990-7be18e22664f@infradead.org>
Date:   Sat, 8 Aug 2020 22:05:53 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Jim Cromie <jim.cromie@...il.com>, jbaron@...mai.com,
        linux-kernel@...r.kernel.org
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Changbin Du <changbin.du@...el.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH 3/7] dyndbg: select ZPOOL in Kconfig.debug

On 8/7/20 1:09 PM, Jim Cromie wrote:
> dyndbg will next need zs_malloc and friends, so add config reqs now,
> to avoid touching make-deps late in a patch-set.
> 
> I used select in order not to hide dyndbg inadvertently.
> I want to say recommends, since it could be an optional feature.
> Whats the best way ?

Hi Jim,
Can you elaborate on what/why/when it could be an optional feature?

> 
> Signed-off-by: Jim Cromie <jim.cromie@...il.com>
> ---
>  lib/Kconfig.debug | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 9ad9210d70a1..a7973063baf0 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -100,6 +100,7 @@ config DYNAMIC_DEBUG
>  	depends on PRINTK
>  	depends on (DEBUG_FS || PROC_FS)
>  	select DYNAMIC_DEBUG_CORE
> +	select ZPOOL
>  	help
>  
>  	  Compiles debug level messages into the kernel, which would not
> 


-- 
~Randy